fix compilation on cygwin #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I am unsure if it was intentional not to target Cygwin, but based on what the modified line was targeting, it appears the line is attempting to detect compilation environments. Cygwin is a Windows-based Unix-like POSIX environment. So while it compiles on Windows (i.e..
defined(_WIN32), for MSVC), it ultimately gets compiled with Unix tools like GCC or Clang on a Windows environment, and can be detected with the__CYGWIN__preprocessor define.Compilation of the C Python bindings for miasm fails because it does not detect the Cygwin environment on compilation. The fix is pretty simple. Miasm is working great on my system now.
Let me know if it was intentional not to target Cygwin, I can see why you might not want to have so many platforms to support on your plate, but if you're targetting MinGW32, I don't see why you couldn't also support Cygwin.