Fix windows build #291
Merged
Fix windows build #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JeremieSpiesser ! Thank you for the fix. We were aware of the ffmpeg version, but made some "time delay" for some old OS (think Centos7). But it may be time to update it now, as we are reaching the EOL. Can you signoff the commit to pass the DCO? |
JeremieSpiesser
force-pushed
the
fix-windows-build-30-04-2024
branch
2 times, most recently
from
af4684d
to
4703bc0
Compare
added 2 commits
May 22, 2024 08:35
Signed-off-by: Jeremie Spiesser <jeremie.spiesser@qarnot-computing.com>
Signed-off-by: Jeremie Spiesser <jeremie.spiesser@qarnot-computing.com>
serpilliere
force-pushed
the
fix-windows-build-30-04-2024
branch
from
ee6fb90
to
2682901
Compare
|
Thank you for the fix @JeremieSpiesser ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢,
I had two errors when building sanzu for windows.
pacman -SyuThis PR makes it possible to build again for windows by
On the "latest" channel, there is no n4.x version anymore for ffmpeg so I used version n6.1. It seems to work fine from my limited testing (machine with an intel gpu using
h264_qsv)