Fix Mac OS X Sierra introduce clock_gettime #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>
This was referenced Aug 7, 2017
asvitkine
approved these changes
Aug 9, 2017
|
Thanks! |
ianfixes
pushed a commit
to emaculation/macemu
that referenced
this pull request
Mar 1, 2019
This reverts commit 35ca220. Going with cebix/macemu#115 instead.
rakslice
pushed a commit
to rakslice/macemu
that referenced
this pull request
Oct 16, 2020
Fix Mac OS X Sierra introduce clock_gettime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OS X Sierra introduce clock_gettime. This breaks HAVE_CLOCK_TIME macro and corresponding get time logic. Because now Sierra has its clock_gettime function while the earlier Mac don't.
The simple fix that won't break Mac OS X earlier than Sierra is to move HAVE_CLCOK_GETTIME down and let Mac OS X condition check up. In this case, the old way is always used regardless of the existence of clock_gettime in different Mac OS X.
I tested it on Sierra and Linux. It works. In theory, it should also work for earlier Mac OS X.