Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SheepShaverLauncher for modern XCode and OS X #25

Closed
wants to merge 2 commits into from

Conversation

vasi
Copy link
Contributor

@vasi vasi commented Mar 28, 2013

Minor fixes to allow SheepShaverLauncher to compile out-of-the--box on the 10.6 SDK and XCode 4.x. I don't anticipate the changes breaking earlier versions, though I have not been able to test.

The previous Mac SDK setting, 10.4, is very old and does not allow compilation
on recent versions of OS X. Same with the compiler, gcc 4.0.

Since SheepShaver doesn't purposefully target a specific SDK or compiler,
it's better to just use XCode's default, which should always be usable.
If a user wants a specific SDK, they can set it themselves.
On Mac OS X 10.6, many informal protocols have become formal, and failure to
declare conformance to them is an error. Declare our delegates and data sources
to be conformant, conditional on an SDK >= 10.6
@asvitkine
Copy link
Collaborator

Can you split the source file changes and the project file change?

I'm reluctant to take the proj file change, since I'd like to keep the project able to produce binaries that work on 10.4.

@vasi
Copy link
Contributor Author

vasi commented Mar 29, 2013

Thanks for the quick reply.

I agree that we shouldn't specify an SDK of 10.6 or something. I just think it's better to specify no SDK at all (and let XCode select its default) instead of specifying an SDK that may not exist.

In any case, if you really just want the source file change, it's already in a separate commit. You should be able to 'git fetch' from my repo and then 'git cherry-pick' the second commit "Compile on 10.6+ SDK", which still leaves 10.4 as the default SDK.

@vasi
Copy link
Contributor Author

vasi commented Apr 4, 2013

While we're at it, it would be great if SheepShaverLauncher's add disk dialog allowed the selection of sparsebundles. We could just set [open setCanChooseDirectories:YES]. But I'm not sure why we treat bundles as directories in the first place. Is there a reason for the [open setTreatsFilePackagesAsDirectories:YES] call?

@RonaldPR
Copy link

RonaldPR commented Apr 4, 2013

Isn't that to allow open and save dialogs to have access to files inside .sheepvm virtual machine packages?


Op 4 april 2013, om 16:04, schreef Dave Vasilevsky notifications@github.com:

While we're at it, it would be great if SheepShaverLauncher's add disk dialog allowed the selection of sparsebundles. We could just set [open setCanChooseDirectories:YES]. But I'm not sure why we treat bundles as directories in the first place. Is there a reason for the [open setTreatsFilePackagesAsDirectories:YES] call?


Reply to this email directly or view it on GitHub.

@vasi
Copy link
Contributor Author

vasi commented Apr 4, 2013

Oh, I never considered that anyone might do that! Ok, in that case I guess the best thing to do is use setCanChooseDirectories:YES. It's a little weird to expose the internals of sparsebundles, but I can't think of anything better.

@RonaldPR
Copy link

RonaldPR commented Apr 4, 2013

That is how you manage (choose, add, create, remove) the files inside the virtual machine, either with the Launcher or with the SheepShaver built-in prefs editor, regardless whether the VM is a folder or a .sheepvm bundle.


Op 4 april 2013, om 16:34, schreef Dave Vasilevsky notifications@github.com:

Oh, I never considered that anyone might do that!

vasi added a commit to vasi/macemu that referenced this pull request Mar 6, 2014
Users should be able to select sparsebundles in the disk prefs, but should
still be able to navigate inside .sheepvm bundles.

See cebix#25 (comment)
ianfixes pushed a commit to emaculation/SheepShaver that referenced this pull request Mar 1, 2019
Users should be able to select sparsebundles in the disk prefs, but should
still be able to navigate inside .sheepvm bundles.

See cebix/macemu#25 (comment)
@vasi vasi closed this Aug 6, 2023
@vasi
Copy link
Contributor Author

vasi commented Aug 6, 2023

Super out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants