Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template strings are not considered as a string in stringRegex #36

Closed
leftyftw opened this issue Mar 27, 2017 · 1 comment · Fixed by #37
Closed

Template strings are not considered as a string in stringRegex #36

leftyftw opened this issue Mar 27, 2017 · 1 comment · Fixed by #37

Comments

@leftyftw
Copy link
Contributor

leftyftw commented Mar 27, 2017

Given a template such as:

import { Component, OnInit } from '@angular/core';

@Component({
    moduleId: module.id,
    selector: 'naics-lookup',
    templateUrl: 'naics-lookup.component.html',
    styleUrls: ['naics-lookup.component.css']
})
export class NaicsLookupComponent implements OnInit {
    constructor() { }

    ngOnInit() { }
}

The plugin works fine. However, given the component:

import { Component, OnInit } from '@angular/core';

@Component({
    moduleId: module.id,
    selector: `naics-lookup`,
    templateUrl: `naics-lookup.component.html`,
    styleUrls: [`naics-lookup.component.css`]
})
export class NaicsLookupComponent implements OnInit {
    constructor() { }

    ngOnInit() { }
}

The plugin fails to recognize the backticks as strings.

leftyftw added a commit to leftyftw/rollup-plugin-angular that referenced this issue Mar 27, 2017
Add backtick (`) as possible string marker to fix cebor#36.
@cebor
Copy link
Owner

cebor commented Aug 1, 2017

Sorry, i do not maintain this plugin for rollup anymore.

See: https://github.com/cebor/rollup-plugin-angular/blob/master/README.md#looking-for-new-maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants