Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

able to save sandwiches #16

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zachjamesgreen
Copy link

Added the ability to save custom and preset sandwiches to local storage so the the user can see past sandwiches they may not remember.

@cecilbowen
Copy link
Owner

I've checked this out on your demo site, and it looks like a good idea. I noticed you changed the URL and all that to your site in this pull request, so I'm not sure if you meant to do that here or perhaps just on your branch.

I'm all about saving on screen space -- the less the user has to scroll vertically to see content, the better, so I would prefer a horizontal scroll over vertical for this. I would also make it a toggle, off by default, again, to save on screen space. I'm not a fan of the fixed source code link overlay. It's not something I need to see/have access to all the time, so it was fine at the bottom. As for the save boxes, me personally, all I would really need to see on them is the effects (power, type, level), name and star level. Honestly, when you get down to it, the boxes are really not that functionally different from the clickable bubbles to load the preset game recipes in the search panel, so maybe the custom sandwiches could somehow work with fitting in there instead (via appending to the end or a toggle between preset/saved sandwiches view). Might even change the search panel to work as an AND search instead of the current OR search. So they might not even need to display anything but the name if that route is taken. Could even add a button or some prompt right next to the stars of a custom sandwich that allows changing the name inline. The ingredient images are just extra, and add to the box size. The boxes can get to a point with either a really long name or a lot of ingredients, where they expand past the screen, making the whole page look off by being scroll-able left/right and really awkward to access on mobile. I would probably put the "Save Sandwich" button smack dab in the bottom-center of the current sandwich image, and rename it to be a "Save"/"Remove" toggle or something similar. Speaking of saving, you're able to save preset sandwiches and also multiples of the same sandwich, and I don't really see the point in that.

This all probably seems really nitpicky for the amount I've mentioned, but I've just given you my honest suggestions based on how I would see myself using this feature as a user of the program. I'm not entirely sure how I would lay all of this out myself, though, so these really are more suggestions than hard guidelines. So don't take all this as me knocking the work, it's a great concept, I'm just thinking of the improvements.

@cecilbowen cecilbowen marked this pull request as draft December 28, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants