Use PE to implement GetLists
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaobo He <shaobohe@amazon.com>
mwhicks1
requested changes
May 20, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
andrewmwells-amazon
approved these changes
Jun 3, 2024
Signed-off-by: Shaobo He <shaobohe@amazon.com>
mwhicks1
approved these changes
Jun 17, 2024
Comment on lines
+521
to
+523
| let partial_response = | ||
| self.authorizer | ||
| .is_authorized_partial(&partial_request, &self.policies, &entities); |
There was a problem hiding this comment.
Maybe add a comment explain what's going on here, because readers might be confused.
What we are trying to simulate is the following:
- For all entities L of type List,
is_authorized(principal,GET_LIST,L)? If so, add to collection
What we are doing here instead is
- Let res =
is_authorized_partial(principal,GET_LIST,unknown). - For all entities L of type List, is res
.reauthorize(unknown=L)? If so, add to collection
The benefit is that we are partially evaluating some of the policies so the reauthorization requires less work. Even more, we imagine that a future implementation of the entity store can implement the reauthorize logic more directly/efficiently, e.g., as a DB query.
There was a problem hiding this comment.
Noted. Will fix it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: