Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos, uniformity fixes in docs #131

Merged
merged 3 commits into from
May 22, 2024
Merged

typos, uniformity fixes in docs #131

merged 3 commits into from
May 22, 2024

Conversation

mwhicks1
Copy link
Contributor

Description of changes: typos in README, uniformity in filenames

Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but not sure about one of the changes (below)

| `*.cedarschema.json` | Example schema |
| `policies.cedar` | Cedar policies |
| `entities.json` | Sample entity store |
| `policies.cedarschema` | Cedar schema |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think policies.cedarschema makes sense for a schema filename

@shaobo-he-aws shaobo-he-aws merged commit 52a9825 into main May 22, 2024
7 checks passed
@shaobo-he-aws shaobo-he-aws deleted the cedar-examples-typos branch May 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants