Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Policy and Template APIs consistent wrt annotations #1116

Closed
1 of 2 tasks
cdisselkoen opened this issue Aug 6, 2024 · 0 comments · Fixed by #1131
Closed
1 of 2 tasks

Make Policy and Template APIs consistent wrt annotations #1116

cdisselkoen opened this issue Aug 6, 2024 · 0 comments · Fixed by #1131
Labels
feature-request This issue requets a substantial new feature

Comments

@cdisselkoen
Copy link
Contributor

Category

User level API features/changes

Describe the feature you'd like to request

As noted in this TODO in the code

PolicySet has two methods annotation() and template_annotation() which are very similar except that one expects a policy ID and one expects a template ID. However, the former returns Option<&str> and the latter returns Option<String>. We should make this consistent; I think Option<&str> is better.

Describe alternatives you've considered

We could converge on Option<String> instead.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requets a substantial new feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant