Remove ParseErrors::errors_as_strings

[aaronjeline]

Category

Internal refactors/changes

Describe the feature you'd like to request

It's not necessary and not public

Describe alternatives you've considered

Leave it

Additional context

No response

Is this something that you'd be interested in working on?

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

[cdisselkoen]

I think it might be public. It's a pub method on the ParseErrors type, which is exposed in cedar-policy (see docs.rs docs for 3.0).

It is problematic though because, as we continue to invest more in miette, it only grabs the main error message, not any of the other miette data such as error code or help string

[john-h-kastner-aws]

Bumping this as a breaking change to make alongside the rest of the breaking changes to the error API in #745

[cdisselkoen]

Yes. I believe that #800 removed the last user of this API

[john-h-kastner-aws]

Turns out #616 and #729 added three uses of this function in the wasm crate.

[cdisselkoen]

Those should probably be replaced by uses of the new ffi::DetailedError

[cdisselkoen]

(That's the substitution that #800 made in the other APIs)