Rewrite of EntitiesError
#828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjeline
force-pushed
the
aaronjeline/entities-745-pass
branch
3 times, most recently
from
f587eb6
to
942cef2
Compare
shaobo-he-aws
approved these changes
May 1, 2024
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
aaronjeline
force-pushed
the
aaronjeline/entities-745-pass
branch
from
53b06be
to
6bdbc91
Compare
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
john-h-kastner-aws
approved these changes
May 3, 2024
| @@ -73,8 +73,45 @@ pub mod entities { | |||
| self.inner.size_hint() | |||
| } | |||
| } | |||
|
|
|||
| /// Errors around entities | |||
| pub mod err { | |||
cdisselkoen
reviewed
May 6, 2024
Comment on lines
+390
to
+395
| /// Error type for an expression that is not a record | ||
| #[derive(Debug)] | ||
| pub struct NotARecord { | ||
| /// Expression which is not a record | ||
| expr: Box<RestrictedExpr>, | ||
| } |
There was a problem hiding this comment.
I know I'm late and this has already been merged, but since this is an error type, it would probably make sense for it to derive Error, and have the error message defined here (and ContextCreationError::NotARecord just have error(transparent))
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rewrite of entities error to bring inline with our general error strategy
Issue #, if available
#645
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):