Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align EntityAttrEvaluationError with cedar#745 #849

Merged
merged 1 commit into from
May 8, 2024

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

Implement the suggestions in #745 as applied to EntityAttrEvaluationError

This type is used both as the opaque struct in the variant of a larger error (SchemaError) and on its own as an error type (for Entity::new()). The guidelines in #745 are ambiguous whether all errors used as standalone error types need to be enums. I made a judgment call to not make this one a one-variant enum, at least in this case.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen merged commit 578c77d into main May 8, 2024
16 of 17 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/entity-attr-evaluation-error branch May 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants