-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align EvaluationError
and ExtensionFunctionLookupError
with cedar#745
#860
Conversation
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left some minor comments & questions.
Looking at this again, I think |
Signed-off-by: Craig Disselkoen <cdiss@amazon.com> Co-authored-by: Kesha Hietala <khieta@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com> Co-authored-by: Kesha Hietala <khieta@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
I think that we don't need the |
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Description of changes
Implement the suggestions in #745 for
EvaluationError
(and the previously-not-publicExtensionFunctionLookupError
, which it references)Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
(covered by existing changelog entry)
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)