Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align EvaluationError and ExtensionFunctionLookupError with cedar#745 #860

Merged
merged 5 commits into from
May 17, 2024

Conversation

cdisselkoen
Copy link
Contributor

Description of changes

Implement the suggestions in #745 for EvaluationError (and the previously-not-public ExtensionFunctionLookupError, which it references)

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

(covered by existing changelog entry)

I confirm that cedar-spec (choose one, and delete the other options):

  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some minor comments & questions.

cedar-policy-core/src/error_macros.rs Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Outdated Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Outdated Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Show resolved Hide resolved
cedar-policy-core/src/evaluator/err.rs Outdated Show resolved Hide resolved
cedar-policy-core/src/extensions.rs Outdated Show resolved Hide resolved
cedar-policy-core/src/extensions.rs Outdated Show resolved Hide resolved
@khieta
Copy link
Contributor

khieta commented May 13, 2024

Looking at this again, I think ExtensionFunctionLookupError might have been previously public-ish due to the pub use cedar_policy_core::extensions in api.rs -- is it possible to remove the pub use there now?

cdisselkoen and others added 3 commits May 14, 2024 07:54
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>

Co-authored-by: Kesha Hietala <khieta@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>

Co-authored-by: Kesha Hietala <khieta@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen
Copy link
Contributor Author

I think that we don't need the extensions module public at the moment, because the Extensions type doesn't appear anywhere in our public API signatures. I've pushed a commit removing the extensions module from the cedar-policy API.

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen cdisselkoen merged commit 2b7fe99 into main May 17, 2024
16 of 17 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/evaluation-error branch May 17, 2024 13:03
@khieta khieta mentioned this pull request May 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants