forward extra kwargs from py_venv to its internal targets #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getim
commented
Nov 25, 2022
| ) | ||
|
|
||
| py_binary( | ||
| name = name, | ||
| srcs = ["@rules_pyvenv//:build_env.py"], | ||
| deps = ["@rules_pyvenv//vendor/importlib_metadata"], | ||
| deps = ["@rules_pyvenv//vendor/importlib_metadata"], |
There was a problem hiding this comment.
also fixed a line with some weird whitespace 🙂
getim
changed the title
jvolkman
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
py_venv-macro does not accept any of Bazel's common build rule attributes because it limits itself to the 3 arguments it knows about. This PR makes it so that the macro accepts any extra arguments that are valid for both the internal_py_venv_depsandpy_binarytarget and forwards them to those targets.After this change, things like
tags,visibilityortestonlyare supported onpy_venvand have the expected behaviour.