Specifying itShouldBehaveLike with a shared example group name that d…

…oesn't exist will now throw an exception, rather than giving an EXC_BAD_ACCESS.
cedarbdd · Aug 12, 2011 · 4645d89 · 4645d89
1 parent 9a6a1f0
commit 4645d89
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/Source/CDRSharedExampleGroupPool.m b/Source/CDRSharedExampleGroupPool.m
@@ -16,6 +16,10 @@ void sharedExamplesFor(NSString *groupName, CDRSharedExampleGroupBlock block) {
 
 void itShouldBehaveLike(NSString *groupName) {
     CDRSharedExampleGroupBlock sharedExampleGroupBlock = [[[SpecHelper specHelper] sharedExampleGroups] objectForKey:groupName];
+    if (!sharedExampleGroupBlock) {
+        NSString *message = [NSString stringWithFormat:@"Unknown shared example group with description: '%@'", groupName];
+        [[NSException exceptionWithName:NSInternalInconsistencyException reason:message userInfo:nil] raise];
+    }
 
     CDRExampleGroup *parentGroup = currentSpec.currentGroup;
     currentSpec.currentGroup = [CDRExampleGroup groupWithText:[NSString stringWithFormat:@"(as %@)", groupName]];

diff --git a/Spec/SpecSpec.mm b/Spec/SpecSpec.mm
@@ -163,6 +163,15 @@ void expectFailure(CDRSpecBlock block) {
     itShouldBehaveLike(@"a shared example group that contains a failing spec");
 });
 
+describe(@"a describe block that tries to include a shared example group that doesn't exist", ^{
+    @try {
+        itShouldBehaveLike(@"a unicorn");
+    } @catch (NSException *) {
+        return;
+    }
+    [NSException exceptionWithName:NSInternalInconsistencyException reason:@"Should have thrown an exception" userInfo:nil];
+});
+
 SPEC_END