Fix multiple stubs with different primitive args #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoru
added a commit
that referenced
this pull request
Aug 13, 2013
Fix multiple stubs with different primitive args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken test case, but I'd like some feedback on how to do this better. In particular, I'm not super comfortable with using typeid(). I'd prefer line 72 on StubbedMethod.mm to be:
if (Arguments::anything.get() == argument_ptr.get()) {
This doesn't work because Arguments::anything doesn't always return a shared pointer to the same Arguments::AnyArgument instance. Shouldn't it do that since it's statically initialized? (AnyArgument.h:24)