Add support for OpenSSL 3.0 #5
Conversation
Fixes cedarcode#4 `ECDSA::SigningKey` and `RSA::SigningKey` are changed to wrap the OpenSSL PKey classes instead of inheriting them, because there seem to be no way with version 3.0.0 of the `openssl` gem to generate such PKeys without using a `.generate` factory method.
There was a problem hiding this comment.
So grateful for this contribution (and the other associated PRs)! ❤️
Left a question. I'm not used to this codebase so I'll take me a bit to get up to speed to understand in depth the proposed changes.
Again sorry for the delay, and thank you for the patience
| class SigningKey | ||
| extend Forwardable | ||
|
|
||
| def_delegators :@pkey, :sign, :verify | ||
| def_delegators :@pkey, :public_key, :private_key, :to_pem, :to_der, :public?, :private?, :export, :to_s | ||
| def_delegators :@pkey, :public_encrypt, :public_decrypt, :private_encrypt, :private_decrypt | ||
| def_delegators :@pkey, :sign_pss, :verify_pss | ||
| def_delegators :@pkey, :blinding_off!, :blinding_on! | ||
| def_delegators :@pkey, :params, :to_text | ||
|
|
||
| def initialize(*args) | ||
| @pkey = OpenSSL::PKey::RSA.generate(*args) | ||
| end |
There was a problem hiding this comment.
I'm not sure what you mean, but the code you pointed means that when SigningKey.new(size) is called, OpenSSL::PKey::RSA#new bypasses inheritance by creating a new OpenSSL::PKey::RSA object in OpenSSL::PKey::RSA.generate. I'm not sure we can do without delegating.
A more maintainable way to delegate my be by using the Delegator class, though. Doing that.
There was a problem hiding this comment.
Thank you for finding a workaround to listing delegations like before. I think this way nicer and maintainable 👍
|
@ClearlyClaire just released this under https://rubygems.org/gems/openssl-signature_algorithm/versions/1.2.1 Thank you again for your work on this 🙏 |
Fixes #4
ECDSA::SigningKeyandRSA::SigningKeyare changed to wrap the OpenSSLPKeyclasses instead of inheriting them, because there seem to be no way with version 3.0.0 of theopensslgem to generate such PKeys without using a.generatefactory method.