docs: remove TODO comments for attestation type and path

[bdewater]

The W3C spec states at the end of every verification procedure for a attestation type:

If successful, return implementation-specific values representing attestation type and attestation trust path

Thus the TODO comment makes no sense, we need to call valid? to make this data available

[grzuy]

Hi @bdewater,

My reasoning behind those TODO comments was something like:

Wouldn't be better for the gem to "just call verification and then return whatever the result was" instead of "returning nil (like saying I don't know)", in case #attestation_type is called before (or even without) calling valid? or verify?

We'll still match the spec. Just easing the ruby gem usage experience.

[bdewater]

Ah, I see what you mean now. However I'm a little wary of this 'friendly' behaviour when it comes to failure cases. Would we return nil for attestation type in that case? If so, do we actually provide a tangible benefit for an app developer using this gem if the result can still be that?

IMO it's not an unreasonable ask to a developer to use the APIs as intended/correctly :) and right now I'm leaning towards making that more explicit by raising in case you call things in the wrong order, but I'm open to other ideas.

[grzuy]

Let's remove the TODO by merging this and continue discussion in an issue :-)