feat: Accept rp_id explicitly on *Response#valid? #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes cedarcode#72 RP ID may be different from request origin; i.e. client may override, or the appid extension may give legacy app id as a RP ID. In most cases, rp_id can be expected to be a host part of request origin URI. So this patch allows `valid?` methods to take optional `rp_id`, then the methods handle the explicitly given one as a RP ID, instead of a host of origin URI, when it's given.
|
Would it be possible to review this for inclusion in a release soon? This is the main thing that is blocking us from this library, and would solve #78 for us. |
|
Thank you for your work on this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
RP ID may be different from request origin; i.e. client may override, or the appid extension may give legacy app id as a RP ID.
In most cases, rp_id can be expected to be a host part of request origin URI. So this patch allows
valid?methods to take optionalrp_id, then the methods handle the explicitly given one as a RP ID, instead of a host of origin URI, when it's given.