Harden variance string parser with exceptions

cedmans · Nov 15, 2019 · 83437ea · 83437ea
1 parent eb9d8ac
commit 83437ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/2018/01-frequency-changes/src/Frequency.re b/2018/01-frequency-changes/src/Frequency.re
@@ -1,4 +1,6 @@
 [@bs.val] external __dirname: string = "__dirname";
+exception InvalidVarianceString(string);
+exception InvalidSign;
 
 let inputFilename = "input.txt";
 
@@ -13,14 +15,13 @@ let parseVariance = (varianceString: string) => {
   let r = [%re "/([+-])(\\d+)/"];
   let result = Js.String.match(r, varianceString);
   switch (result) {
-  | None => 0
   | Some([|_entire, sign, value|]) =>
     switch (sign) {
     | "+" => int_of_string(value)
     | "-" => int_of_string(value) * (-1)
-    | _ => 0
+    | _ => raise(InvalidSign)
     }
-  | _ => 0
+  | _ => raise(InvalidVarianceString(varianceString))
   };
 };
 let parseVariances = (varianceStrings: array(string)) =>

diff --git a/2018/01-frequency-changes/src/input.txt b/2018/01-frequency-changes/src/input.txt
@@ -957,4 +957,4 @@
 +17
 -15
 +19
--72362
+-72362