Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new methods and fixed breaking moment simple format test case #48

Merged
merged 1 commit into from Oct 24, 2019

Conversation

shubhamV123
Copy link
Contributor

Following items in these commits :

  1. Added lodash get function
  2. new Intl.DateTimeFormat is not giving the date in which moment formatted the date which causes test failing. Fixed it. ** Solution **: Simply added vanilla date string interpolation

@cedmax
Copy link
Owner

cedmax commented Oct 20, 2019

Hi @shubhamV123, thanks for your contribution.
I have to ask if you could isolate the new implementation from the moment fix: the latter has been tackled in another PR which uses a similar approach. I'd love to get the get implementation in 😊

@shubhamV123
Copy link
Contributor Author

@cedmax I can't push the code of because of that test failing that's why I have to add a fix for that code. Either you merge that code to master first. Then I will give you pull request again.

@cedmax
Copy link
Owner

cedmax commented Oct 20, 2019 via email

@shubhamV123
Copy link
Contributor Author

Cool. Let me know once it's fixed. If required I will reraise pull request.

@cedmax
Copy link
Owner

cedmax commented Oct 24, 2019

Hi @shubhamV123, I removed that test, if you merge master and choose it over your changes you should be able to push the new code without problems

@shubhamV123
Copy link
Contributor Author

@cedmax Rebased my branch with upstream. Now you can merge with get code.

@cedmax cedmax merged commit 7eb1883 into cedmax:master Oct 24, 2019
@cedmax
Copy link
Owner

cedmax commented Oct 24, 2019

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants