Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto & merge lsb with lsbset #34

Merged
merged 9 commits into from Nov 13, 2022

Conversation

FlavienRx
Copy link
Contributor

Hi guys 馃憢

I used your project in a personal project running on a small server (256 Mo) and when I used big image, the server run out of memory and crashed. So I deeg in your lib to find out that img_list variable in lsbset.py took lot of memory. I started to refacto this and lot of refacto appears like merge lsb.py and lsbset.py. I hope my commits are clear.

Et merci @cedricbonhomme pour avoir initi茅 le projet 馃槈

@FlavienRx FlavienRx changed the title Refacto Refacto & merge lsb with lsbset Nov 13, 2022
@cedricbonhomme
Copy link
Owner

Hello !

Thank you very much for the PR. I am always happy to have contributions, and this one is really nice. And it's cool if it is now working on your small server.

I already had a quick look at the commits. Everything seems fine.
I'll check with a bit more caution later. If fine for you, I can add your name in the file with the list of contributors. Then I'll publish a new package on Pypi as this deserves a new release.

Thank you !

@cedricbonhomme cedricbonhomme merged commit 43b963d into cedricbonhomme:master Nov 13, 2022
@FlavienRx
Copy link
Contributor Author

Wow, fast merge 馃槷

If fine for you, I can add your name in the file with the list of contributors.

It will be a pleasure.

Then I'll publish a new package on Pypi as this deserves a new release.

I didn't change files __revision__ and __version__ and I think next step is to run Black and Flake8 on the project to get all files well formatted.

@cedricbonhomme
Copy link
Owner

cedricbonhomme commented Nov 14, 2022

Wow, fast merge open_mouth

If fine for you, I can add your name in the file with the list of contributors.

It will be a pleasure.

OK !

Then I'll publish a new package on Pypi as this deserves a new release.

I didn't change files __revision__ and __version__ and I think next step is to run Black and Flake8 on the project to get all files well formatted.

Yes, I'll also see some mypy warnings. It's fine for Black. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants