Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No config file silently ignored #6

Closed
Roland0 opened this issue Feb 11, 2024 · 2 comments
Closed

No config file silently ignored #6

Roland0 opened this issue Feb 11, 2024 · 2 comments

Comments

@Roland0
Copy link

Roland0 commented Feb 11, 2024

Thanks for your work on pyHIDS it has inspired me.

While looking at your code (and using it) I noticed that this try block will never raise an exception as the config.read() method silently fails (by design) and returns an empty list.

I've noticed a few similar issues around the config file, I'm writing a PR (or PRs) if you're happy with that :)

@cedricbonhomme
Copy link
Owner

cedricbonhomme commented Feb 11, 2024

Hi !

Indeed, it's partly intentional (and perhaps a touch of laziness on my part). I opted to let the user create their own config file using the provided example. However, I acknowledge that there's room for enhancement in this aspect. Clearly !
Therefore, I'm fully supportive of a pull request to address these improvements. :-)

Thank you !

@cedricbonhomme
Copy link
Owner

I close the ticket with this little change. But if you have other improvements concerning the loading of the configuration file, feel free to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants