Don't set format to RASPICAM_FORMAT_BGR #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RASPICAM_FORMAT_BGR, so changed to RASPICAM_FORMAT_RGB
|
Interesting, and great fix! Do you have screenshot of "before" and "after". I would like to see the results. Thank you mike. |
|
Thanks for merging. These are before and after screenshots:
|
|
Your change will have fixed things for newer firmwares, but broken it for old ones. See https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=148432 for details of why things changed and how to support either. By the looks of it you've forked the raspicam-0.1.3 project to make this one, in which case there is a clean patch available at https://github.com/6by9/raspicam-0.1.3. |
|
Thanks for letting us know @6by9 ! I'll add the patch 👍 |
Closed
cedricve
pushed a commit
that referenced
this pull request
Dec 3, 2016
* raspicam sensor_mode support. (#11) * Sensor mode setting implemented for private_impl, CV_CAP_PROP_MODE support added for raspicam_cv. * fixed default value for sensor_mode. * build fix (#12) * Sensor mode setting implemented for private_impl, CV_CAP_PROP_MODE support added for raspicam_cv. * fixed default value for sensor_mode. * fixed duplicates case values. * My Raspberry Pi Camera has red and blue swaped when setting format to RASPICAM_FORMAT_BGR, so changed to RASPICAM_FORMAT_RGB (#13) * Fix bgr/rgb inversion (#17) * fix RGB and BGR inversion * Revert previous change due to RGB/BGR inversion Opencv uses BGR color space * added number of camera to open Signed-off-by: root <root@ubuntu.ubuntu-domain> * implemented getter and setter (for sake of implemention i guess) Signed-off-by: root <bspecjalny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Kerberos.io with my Raspicam, red and blue were switched in all captures. I'm probably missing something but changing the format fixed it for me.