Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Permissions #2

Open
JesusMcCloud opened this issue Oct 27, 2017 · 2 comments
Open

Broken Permissions #2

JesusMcCloud opened this issue Oct 27, 2017 · 2 comments

Comments

@JesusMcCloud
Copy link
Contributor

Packaging the tor files into a zip erases file permissions.
This essentially makes it impossible to execute binaries after unpacking (without keeping a list of files to be marked executable).
Fix proposed in pull request 1

@JesusMcCloud
Copy link
Contributor Author

JesusMcCloud commented Oct 27, 2017

Switching to tar-based packaging (necessary for keeping permissions intact) triggers a bug in the maven shade plugin (when referencing tor-binary as part of a project which employs the maven-shade-plugin).

EDIT: switching to tarballs does not help either, since ant still loses permissions

@JesusMcCloud
Copy link
Contributor Author

Fixed here.
Cannot be auto-merged, though

cedricwalter pushed a commit that referenced this issue Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant