Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document enhancement about override flags #222

Closed
yousefak007 opened this issue Mar 1, 2024 · 5 comments
Closed

document enhancement about override flags #222

yousefak007 opened this issue Mar 1, 2024 · 5 comments

Comments

@yousefak007
Copy link

hi, thank you for doing this library

I see some people complain about some inaccurate flags, and this library depends on circle_flags lib, and it needs to change or update flags on that library first

for example, Saudi and Iraq flags are inaccurate

for an easy solution and rather than waiting, I can override that package assets by doing this:

I just made packages/circle_flags/assets/svg/ folder:

image

then in pubspec.yaml I added in assets:

  assets:
    - packages/circle_flags/assets/svg/

image

it will be helpful if this information is added to the documentation of this library

@cedvdb
Copy link
Owner

cedvdb commented Mar 1, 2024

Good idea

The original flags are there: https://github.com/HatScripts/circle-flags and should be changed there when change are needed.

For the documentation it should be added here:

https://github.com/cedvdb/flutter_country_selector

cedvdb added a commit that referenced this issue Mar 27, 2024
@cedvdb cedvdb closed this as completed in 218848c Mar 27, 2024
@Lionapi
Copy link

Lionapi commented Apr 8, 2024

Hello,

i tried to use the version 9.2.3 of Phone_form_Field and i got this error :
see the attached picture.
error_flutter

can you help me please ?

@cedvdb
Copy link
Owner

cedvdb commented Apr 8, 2024

@Lionapi What does that have to do with flags ? Change to ...PhoneFieldLocalization.delegates (add ... in front, since it's an iterable).

@Lionapi
Copy link

Lionapi commented Apr 8, 2024

@cedvdb I know there's no connection between the two, but after looking for a way to contact you, here's the one I found.
However, even adding it in front as you say, the same error persists and i'm still stuck.

@cedvdb
Copy link
Owner

cedvdb commented Apr 8, 2024

Please create your own issue, with a code snippet using the ... as I suggested above. Also post the error message you are having after using ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants