Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle change on country selection #247

Merged
merged 5 commits into from
May 31, 2024
Merged

fix: handle change on country selection #247

merged 5 commits into from
May 31, 2024

Conversation

Suman085
Copy link
Contributor

The onChange does not trigger when country is updated which is unexpected
The didChange was not called because of which the form was on a bad state

fix: handle change on country selection

@Suman085
Copy link
Contributor Author

@cedvdb #240

@cedvdb
Copy link
Owner

cedvdb commented May 31, 2024

Thanks, for your first contribution.

Could you

  • update the changelog to add an entry this bug was fixed
  • add a test so this doesn't break in the future.

@Suman085
Copy link
Contributor Author

Thanks, for your first contribution.

Could you

  • update the changelog to add an entry this bug was fixed
  • add a test so this doesn't break in the future.

Awesome package though!!! Lemme know if this needs changes

@cedvdb cedvdb merged commit 170203c into cedvdb:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants