Skip to content

Commit

Permalink
adding security notice to writing modules chapter
Browse files Browse the repository at this point in the history
  • Loading branch information
cedwards committed Sep 10, 2015
1 parent 14aaf63 commit b3cec6d
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions chapters/development/writing-modules.rst
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ flag is set to `True`. This means that any shell-specific functionality such as
'echo' or the use of pipes, redirection or &&, should either be migrated to
`cmd.shell` or have the `python_shell=True` flag set here.

**The use of python_shell=True means that the shell will accept _any_ input
including potentially malicious commands such as 'good_command;rm -rf /'. Be
absolutely certain that you have sanitized your input prior to using
python_shell=True**
.. note:: Security Notice

The use of python_shell=True means that the shell will accept _any_ input
including potentially malicious commands such as 'good_command; rm -rf /'. Be
absolutely certain that you have sanitized your input prior to using
python_shell=True

0 comments on commit b3cec6d

Please sign in to comment.