Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from a struct to a class #33

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

BrandonRoehl
Copy link

  • Provided lazy execution on sunrise sunset.
  • class model instead of struct
  • Made it so if you don't specify a date it will move dates if the time changes
    • This is done by having a getter and a private cache on the variables sunset and sunrise
  • Can initialize an instance with a Zenith
  • Backward compatible with the same interfaces and all test passing

I did these updates on a fork for a macOS application I have using this and decided to share the changes. If they don't fit with the current direction of the framework feel free to reject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant