Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve calculation of geometry info for Nek BPs #11

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Dec 5, 2018

I found a minor bug in the geodatq function when converting BP3/4 for libCEED. Specifically, the variable tmp had incorrect values between applying intp_rstd and loc_grad3, leading to minor variations in the correctness of the geometric factors. Creating a variable local to the subroutine than using the one in the common variable space corrected the issue.

The easiest way to verify this error is to insert a write statement for each value of jacmq in geodatq.

Also, I included the determinant of the Jacobian in the geometric factors on BP1/2.

I discovered these small changes because in libCEED we compute the RHS directly rather than calculating the RHS by applying the operator to the true solution. (see the MFEM and PETSc examples) If it is desirable, I add add something like that here.

I do not believe these changes have any performance impact, just a corectness impact.

@jeremylt
Copy link
Member Author

Please let me know if any changes are required for this PR.

@v-dobrev
Copy link
Member

@jeremylt , for this repository, feel free to push directly to master.

@jeremylt jeremylt merged commit 0d37a82 into master Jan 10, 2019
@jeremylt jeremylt deleted the nek-adjust branch January 10, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants