Improve calculation of geometry info for Nek BPs #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a minor bug in the geodatq function when converting BP3/4 for libCEED. Specifically, the variable tmp had incorrect values between applying intp_rstd and loc_grad3, leading to minor variations in the correctness of the geometric factors. Creating a variable local to the subroutine than using the one in the common variable space corrected the issue.
The easiest way to verify this error is to insert a write statement for each value of jacmq in geodatq.
Also, I included the determinant of the Jacobian in the geometric factors on BP1/2.
I discovered these small changes because in libCEED we compute the RHS directly rather than calculating the RHS by applying the operator to the true solution. (see the MFEM and PETSc examples) If it is desirable, I add add something like that here.
I do not believe these changes have any performance impact, just a corectness impact.