Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: if .connect() called more than once, incorrect callbacks are used #133

Open
fedor opened this issue Nov 21, 2016 · 1 comment
Open

Comments

@fedor
Copy link

fedor commented Nov 21, 2016

@ceejbot,

if FiveBeansClient.prototype.connect() called more than once, a callback for an old socket command may exist in self.handlers even after a new socket is created. In this case, the first command with the new socket will stuck, because its callback will not be called (a callback for the old socket will be called instead).

Suggested fix: #132.

@japod
Copy link

japod commented Jul 20, 2017

@ceejbot although this bug could be easily worked around in user code, since there is a PR ready, could you please consider merging it? The bug is quite annoying as the client generates misleading errors after just re-connecting.

bruno-buiret added a commit to bruno-buiret/fivebeans that referenced this issue Aug 31, 2023
bruno-buiret added a commit to bruno-buiret/fivebeans that referenced this issue Sep 1, 2023
* Code review of Buffer use + ceejbot#133
* Ping / Pong example
* Examples
* Make events go up to the runner + Add socket timeout
* Indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants