Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : feat: add pause and resume subscription methods #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rahulbile
Copy link
Contributor

No description provided.

@rahulbile
Copy link
Contributor Author

rahulbile commented Dec 12, 2018

@mrfelton can you please review this PR? This updates the API version to latest and adds new method to pause and resume subscription.

@aaron-junot
Copy link

Please note that there are a lot of breaking changes between API v2.7 and v2.17. Adding just these two methods will not ensure compatibility between this library and the Recurly API v2.17.

If you want to proceed with this PR, I recommend only updating the X-Api-Version to the minimum version which supports pause and resume (v2.11) while ensuring that other changes between 2.7 and 2.11 are supported.

2.10 is a version that had a lot of changes due to credit memos, so I would spend a good amount of time ensuring that Invoices aren't completely broken in the library due to these changes.

If you go that route, it might be better to break it up into several PRs to avoid having a lot of changes in a single PR.

@rahulbile rahulbile changed the title feat: add pause and resume subscription methods WIP : feat: add pause and resume subscription methods Dec 13, 2018
@rahulbile
Copy link
Contributor Author

Yes @aaron-suarez , thanks for your notes. I did observe that and doing the changes needed. We widely use the recurly API in our application, so giving it a good test. Updated the PR to be WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants