feat(layouts): override layout anchor points with user settings #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Players can now choose to override a layout's chosen anchor point with their own preferred HUD location. This won't work well for every layout, but players can decide that for themselves. Added the new option to the settings struct and MCM config. Added new translation strings to support the config. Added a test to ensure that the setting is respected by the anchor_point() function if set. This bottleneck ensures that flattened layouts get the overridden location automatically. To support the test, added a way to specific a refresh-from file for the settings lazy static. The new convenience functions to Layout that match on its variants are also there to support tests. Next step is trying out the new menu option in the game and making sure it looks right.
Tweaked UI text a bit. Turn settings .ini ints into named anchors, not strings (doh). Refresh the layout after a settings change to pick up any anchor location changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Players can now choose to override a layout's chosen anchor point
with their own preferred HUD location. This won't work well for
every layout, but players can decide that for themselves.
Added the new option to the settings struct and MCM config. It's an
enum that allows players to choose from the current list of anchor
names. Added new translation strings to support the config.
apply_settings()now refreshes the layout to pick up anylocation changes.
Added a test to ensure that the setting is respected by the
anchor_point() function if set. This bottleneck ensures that
flattened layouts get the overridden location automatically.
To support the test, added a way to specific a refresh-from file
for the settings lazy static. The new convenience functions to
Layout that match on its variants are also there to support tests.