Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammo Icons: Add support for Skyrim Arrow Overhaul & more #89

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

VainlyStrain
Copy link
Contributor

This adds support for applying custom icons for the arrow types of Skyrim Arrow Overhaul, as well as to bolts, slingshot rocks and darts. If no icon is found, the Arrow fallback icon is used.

@ceejbot
Copy link
Owner

ceejbot commented Dec 14, 2023

My apologies for missing this last week! Taking a look at it now <3

Copy link
Owner

@ceejbot ceejbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Now all we need to do is find some icons. Hmm, I wonder if OCF adds color keywords for these.

@ceejbot ceejbot merged commit 425efce into ceejbot:latest Dec 14, 2023
@VainlyStrain
Copy link
Contributor Author

My apologies, I didn't really consider this when opening the PR (my intention was that users can add their own icons here if desired). However, SAO already has custom arrow type icons in an optional I4 patch. Maybe we can ask the author for permissions to include the extracted SVGs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants