Fix hash ordering bug tickled by perl 5.18.0

[frioux]

No description provided.

[anazawa]

Your patch doesn't solve the problem. A hashref should be passed to CGI.pm's cookie method:

my $newcookie = $self->query->cookie(%options);

To be surprised, the following code:

$query->cookie( 'foo', 'bar', 'baz', 'qux' );

is equivalent to:

$query->cookie( -name => 'foo', -value => 'baz', -path => 'baz', -domain => 'qux' );

An initial dash is important.

If you pass a hashref to CGI#cookie, the method will work as you expect.

[anazawa]

Sorry, i misunderstood. Your patch solves the problem anyway because keys are sorted.
But we don't have to sort keys if we pass a hashref ;)

[frioux]

Hashref would be fine with me if it will get merged, but I've pretty much given up hope at this point and am looking forward to ditching CGI::Application

[anazawa]

I just found your patch here: https://rt.cpan.org/Public/Bug/Display.html?id=81611
and wanted to introduce a better way to fix your problem ;)
I hope your patch will be merged anyway :)

[frioux]

oh yeah, yours is certainly better, I will admit that :-D

[dsteinbrunner]

I noticed you got maintainership on CGI-Application-Plugin-DBH to fix issues there. Any chance of doing the same on this module?

[frioux]

I'd love to, but cees hasn't responded to my emails. Maybe I'll petition for ownership :/

[frioux]

Ok, I got comaint. I will release this shortly. I switched to a hashref as @anazawa recommended. I'll also grab any low hanging RT's I see.

[frioux]

Arg, ironically neither my patch nor @anazawa 's works on anything OLDER than 5.18. I'm trying to find a real solution other than checking the perl version. Ideas welcome.

[frioux]

ok fixed for real now. Was a bug in Devel::Cover

[anazawa]

Thanks for fixing bugs.