Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing prog_uint16 to uint16 #1

Open
cefn opened this issue May 3, 2013 · 2 comments
Open

Changing prog_uint16 to uint16 #1

cefn opened this issue May 3, 2013 · 2 comments

Comments

@cefn
Copy link
Owner

cefn commented May 3, 2013

John Cooper is reporting that he had to change the line...

const prog_uint16_t notes[] PROGMEM =
...to...
const uint16_t notes[] PROGMEM =

...and this seems to be linked to version changes with Arduino as discussed here... logicalzero/gamby#4

We need to decide which is the least nasty choice to make, and possibly use a macro to switch based on version number once we figure out where the issue is.

Note, the Arduino official doctrine is still to use the declaration as per our original http://www.arduino.cc/en/Reference/PROGMEM

@cefn
Copy link
Owner Author

cefn commented May 3, 2013

The preferred change may be from...
const prog_uint16_t
...to...
const unsigned int[] PROGMEM =
...or...
PROGMEM const unsigned int[] =

...but needs testing. Worst of all it seems to depend on the OS which is running, since Arduino distributes a different compiler toolchain in each package.

@choffee
Copy link

choffee commented May 3, 2013

Hi, I am using the Arduino that comes with Debian wheezy 1:1.0.1+dfsg-7 so I think it's essentially 1.0.1 if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants