Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test should wait for selectors with delay #45

Closed
wants to merge 1 commit into from

Conversation

Oberuks
Copy link

@Oberuks Oberuks commented Nov 13, 2022

No description provided.

@amaitland
Copy link
Member

Does the new test fail when you run it locally? Looks like the unit test ran successfully as part of https://ci.appveyor.com/project/cefsharp/cefsharp-dom/builds/45366995

@Oberuks
Copy link
Author

Oberuks commented Nov 14, 2022

I can't run local tests because there is no testCert.cer file to run the CefSharp.Dom.TestServer.
I ran tests on a simple test solution.
My test solution: WinFormsApp4.zip

@amaitland
Copy link
Member

There are instructions for creating the certificate in the contributing guide.

https://github.com/cefsharp/CefSharp.Dom/blob/main/CONTRIBUTING.md#getting-setup

@Oberuks
Copy link
Author

Oberuks commented Nov 14, 2022

I repeated the steps according to your instructions but could not generate a certificate. In the script, I specified my path for the certificate.

New-SelfSignedCertificate -Subject "localhost" -FriendlyName "Puppeteer" -CertStoreLocation "cert:\CurrentUser\My"
Get-ChildItem -Path cert:\CurrentUSer\my | where { $_.friendlyname -eq "Puppeteer" } | Export-Certificate -FilePath D:\Projects\C#\Browser\CefSharp.Dom\lib\PuppeteerSharp.TestServer\testCert.cer

As a result I get еру error

PS D:\2> .\sert.ps1


   PSParentPath: Microsoft.PowerShell.Security\Certificate::CurrentUser\My

Thumbprint                                Subject
----------                                -------
19789A42CCE9409AAF13AF2DD73753F3D8CDA9D2  CN=localhost
Export-Certificate : Недопустимый тип. Входной объект имеет более одного сертификата.
D:\2\sert.ps1:3 знак:88
+ ... peteer" } | Export-Certificate -FilePath D:\Projects\C#\Browser\CefSh ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Export-Certificate], Win32Exception
    + FullyQualifiedErrorId : System.ComponentModel.Win32Exception,Microsoft.CertificateServices.Commands.ExportCertif
   icateCommand

Can you try running my simple solution yourself? It could save a lot of time for both of us.

@amaitland
Copy link
Member

Can you try running my simple solution yourself? It could save a lot of time for both of us.

A unit test is required to debug the issue.

@amaitland amaitland closed this Nov 14, 2022
@amaitland amaitland reopened this Nov 14, 2022
@amaitland
Copy link
Member

The CI builds generate the certificate as part of the build process, another example is https://github.com/cefsharp/CefSharp.Dom/blob/main/appveyor.yml#L15

@Oberuks
Copy link
Author

Oberuks commented Nov 14, 2022

Unfortunately, I don't understand what I need to do.

@Oberuks
Copy link
Author

Oberuks commented Nov 15, 2022

I made a mistake in testing product versions. There is no problem in the current repository at github.com CefSharp.Dom. The problem I described is in the nugget build 2.0.83 dated 9/12/2022.
This PR needs to be closed.

@Oberuks Oberuks closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants