Skip to content

Commit

Permalink
Remove custom delegates and replace with Generic EventHandler<>'s
Browse files Browse the repository at this point in the history
Conflicts:
	CefSharp.WinForms/ChromiumWebBrowser.cs
  • Loading branch information
amaitland committed Jul 1, 2014
1 parent ca14c94 commit 9e67173
Show file tree
Hide file tree
Showing 11 changed files with 20 additions and 76 deletions.
14 changes: 7 additions & 7 deletions CefSharp.WinForms/ChromiumWebBrowser.cs
Expand Up @@ -118,13 +118,13 @@ public object EvaluateScript(string script, TimeSpan? timeout)
return managedCefBrowserAdapter.EvaluateScript(script, timeout.Value);
}

public event LoadErrorEventHandler LoadError;
public event FrameLoadStartEventHandler FrameLoadStart;
public event FrameLoadEndEventHandler FrameLoadEnd;
public event NavStateChangedEventHandler NavStateChanged;
public event ConsoleMessageEventHandler ConsoleMessage;
public event AddressChangedEventHandler AddressChanged;
public event TitleChangedEventHandler TitleChanged;
public event EventHandler<LoadErrorEventArgs> LoadError;
public event EventHandler<FrameLoadStartEventArgs> FrameLoadStart;
public event EventHandler<FrameLoadEndEventArgs> FrameLoadEnd;
public event EventHandler<NavStateChangedEventArgs> NavStateChanged;
public event EventHandler<ConsoleMessageEventArgs> ConsoleMessage;
public event EventHandler<AddressChangedEventArgs> AddressChanged;
public event EventHandler<TitleChangedEventArgs> TitleChanged;
public event IsBrowserInitializedChangedEventHandler IsBrowserInitializedChanged;
public event IsLoadingChangedEventHandler IsLoadingChanged;

Expand Down
8 changes: 4 additions & 4 deletions CefSharp.Wpf/ChromiumWebBrowser.cs
Expand Up @@ -50,10 +50,10 @@ public class ChromiumWebBrowser : ContentControl, IRenderWebBrowser, IWpfWebBrow
public IDownloadHandler DownloadHandler { get; set; }
public ILifeSpanHandler LifeSpanHandler { get; set; }

public event ConsoleMessageEventHandler ConsoleMessage;
public event FrameLoadStartEventHandler FrameLoadStart;
public event FrameLoadEndEventHandler FrameLoadEnd;
public event LoadErrorEventHandler LoadError;
public event EventHandler<ConsoleMessageEventArgs> ConsoleMessage;
public event EventHandler<FrameLoadStartEventArgs> FrameLoadStart;
public event EventHandler<FrameLoadEndEventArgs> FrameLoadEnd;
public event EventHandler<LoadErrorEventArgs> LoadError;

public ICommand BackCommand { get; private set; }
public ICommand ForwardCommand { get; private set; }
Expand Down
9 changes: 1 addition & 8 deletions CefSharp/AddressChangedEventArgs.cs
Expand Up @@ -17,12 +17,5 @@ public AddressChangedEventArgs(string address)
{
Address = address;
}
};

/// <summary>
/// A delegate type used to listen to AddressChanged events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void AddressChangedEventHandler(object sender, AddressChangedEventArgs e);
}
}
1 change: 0 additions & 1 deletion CefSharp/CefSharp.csproj
Expand Up @@ -97,7 +97,6 @@
<Compile Include="LoadErrorEventArgs.cs" />
<Compile Include="FrameLoadStartEventArgs.cs" />
<Compile Include="KeyType.cs" />
<Compile Include="LoadErrorEventHandler.cs" />
<Compile Include="NavStateChangedEventArgs.cs" />
<Compile Include="ICompletionHandler.cs" />
<Compile Include="Internals\BitmapInfo.cs" />
Expand Down
7 changes: 0 additions & 7 deletions CefSharp/ConsoleMessageEventArgs.cs
Expand Up @@ -33,11 +33,4 @@ public ConsoleMessageEventArgs(string message, string source, int line)
/// </summary>
public int Line { get; private set; }
}

/// <summary>
/// A delegate type used to listen to ConsoleMessage events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void ConsoleMessageEventHandler(object sender, ConsoleMessageEventArgs e);
}
9 changes: 1 addition & 8 deletions CefSharp/FrameLoadEndEventArgs.cs
Expand Up @@ -32,12 +32,5 @@ public FrameLoadEndEventArgs(string url, bool isMainFrame, int httpStatusCode)
/// Http Status Code
/// </summary>
public int HttpStatusCode { get; set; }
};

/// <summary>
/// A delegate type used to listen to FrameLoadEnd events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void FrameLoadEndEventHandler(object sender, FrameLoadEndEventArgs e);
}
}
9 changes: 1 addition & 8 deletions CefSharp/FrameLoadStartEventArgs.cs
Expand Up @@ -26,12 +26,5 @@ public FrameLoadStartEventArgs(string url, bool isMainFrame)
/// Is this the Main Frame
/// </summary>
public bool IsMainFrame { get; private set; }
};

/// <summary>
/// A delegate type used to listen to FrameLoadStart events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void FrameLoadStartEventHandler(object sender, FrameLoadStartEventArgs e);
}
}
8 changes: 4 additions & 4 deletions CefSharp/IWebBrowser.cs
Expand Up @@ -12,27 +12,27 @@ public interface IWebBrowser : IDisposable
/// <summary>
/// Event handler for receiving Javascript console messages being sent from web pages.
/// </summary>
event ConsoleMessageEventHandler ConsoleMessage;
event EventHandler<ConsoleMessageEventArgs> ConsoleMessage;

/// <summary>
/// Event handler that will get called when the browser begins loading a frame. Multiple frames may be loading at the same
/// time. Sub-frames may start or continue loading after the main frame load has ended. This method may not be called for a
/// particular frame if the load request for that frame fails. For notification of overall browser load status use
/// OnLoadingStateChange instead.
/// </summary>
event FrameLoadStartEventHandler FrameLoadStart;
event EventHandler<FrameLoadStartEventArgs> FrameLoadStart;

/// <summary>
/// Event handler that will get called when the browser is done loading a frame. Multiple frames may be loading at the same
/// time. Sub-frames may start or continue loading after the main frame load has ended. This method will always be called
/// for all frames irrespective of whether the request completes successfully.
/// </summary>
event FrameLoadEndEventHandler FrameLoadEnd;
event EventHandler<FrameLoadEndEventArgs> FrameLoadEnd;

/// <summary>
/// Event handler that will get called when the resource load for a navigation fails or is canceled.
/// </summary>
event LoadErrorEventHandler LoadError;
event EventHandler<LoadErrorEventArgs> LoadError;

/// <summary>
/// Loads the specified URL.
Expand Down
13 changes: 0 additions & 13 deletions CefSharp/LoadErrorEventHandler.cs

This file was deleted.

9 changes: 1 addition & 8 deletions CefSharp/NavStateChangedEventArgs.cs
Expand Up @@ -21,12 +21,5 @@ public NavStateChangedEventArgs(bool canGoBack, bool canGoForward, bool canReloa
CanGoForward = canGoForward;
CanReload = canReload;
}
};

/// <summary>
/// A delegate type used to listen to NavStateChanged events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void NavStateChangedEventHandler(object sender, NavStateChangedEventArgs e);
}
}
9 changes: 1 addition & 8 deletions CefSharp/TitleChangedEventArgs.cs
Expand Up @@ -17,12 +17,5 @@ public TitleChangedEventArgs(string title)
{
Title = title;
}
};

/// <summary>
/// A delegate type used to listen to TitleChanged events.
/// </summary>
/// <param name="sender">The object that raised the event.</param>
/// <param name="e">The event arguments.</param>
public delegate void TitleChangedEventHandler(object sender, TitleChangedEventArgs e);
}
}

0 comments on commit 9e67173

Please sign in to comment.