Fix return value serialization for async JS bindings (#2167)

cefsharp · Oct 23, 2017 · f029a22 · f029a22
1 parent a4a1cd8
commit f029a22
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/CefSharp.Example/AsyncBoundObject.cs b/CefSharp.Example/AsyncBoundObject.cs
@@ -39,6 +39,14 @@ public void DoSomething()
             Thread.Sleep(1000);
         }
 
+        public JsObject ReturnObject(string name)
+        {
+            return new JsObject
+            {
+                Value = name
+            };
+        }
+
         public JsObject[] ObjectArray(string name)
         {
             return new[] 

diff --git a/CefSharp.Example/Resources/BindingTest.html b/CefSharp.Example/Resources/BindingTest.html
@@ -83,6 +83,16 @@
                     });
                 }
 
+                function asyncObject()
+                {
+                    var call = "Async call (Object): " + Date();
+                    boundAsync.returnObject('CefSharp').then(function (res) {
+
+                        var end = "Result: " + JSON.stringify(res) + " (" + Date() + ")";
+                        writeAsyncResult(call, end);
+                    });
+                }
+
                 function asyncObjectArray()
                 {
                     var call = "Async call (ObjectArray): " + Date();
@@ -98,6 +108,7 @@
                 asyncDivFail();
                 asyncDoSomething();
                 asyncHello();
+                asyncObject();
                 asyncObjectArray();
             </script>
         </p>

diff --git a/CefSharp/Internals/JavascriptObjectRepository.cs b/CefSharp/Internals/JavascriptObjectRepository.cs
@@ -410,6 +410,11 @@ private static bool IsComplexType(Type type)
                 return false;
             }
 
+            if (baseType.IsValueType && !baseType.IsPrimitive && !baseType.IsEnum)
+            {
+                return false;
+            }
+
             return !baseType.IsPrimitive && baseType != typeof(string);
         }