Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting text using the mouse does not work #145

Closed
perlun opened this issue Jul 26, 2013 · 8 comments
Closed

Selecting text using the mouse does not work #145

perlun opened this issue Jul 26, 2013 · 8 comments

Comments

@perlun
Copy link
Member

perlun commented Jul 26, 2013

You can double-click on a word, but not click-and-drag to select a section of text. Haven't checked whether this actually works with the CEF1 branch, but I suspect it does so it's probably a matter of some OnMouse* event not being propagated to CEF properly.

Possibly blocks #136, depending on how critical this is (I think it's not sooo critical, there are other bigger problems at the moment).

@rastating
Copy link
Contributor

I'm having a look into this one at the moment, it seems to be sending the correct information to the OnMouseButton method of the browser wrapper. It doesn't just effect text highlighting on the page though, it seems to be affecting text in input fields as well as drop down boxes.

Someone using an alternative wrapper to CEF seems to be experiencing this exact same issue (see http://www.magpcss.org/ceforum/viewtopic.php?f=14&t=10965).

As per the above post, it also seems there is some missing implementation in CefSharp, got a feeling this may be where the problem resides:

void SetPopupBuffer(int width, int height, const void* buffer)
{
    // TODO: implement
}

I will continue investigating!

@perlun
Copy link
Member Author

perlun commented Oct 28, 2013

Hi,

Many, many thanks for your answer! It's great to get some quality help with this. Regarding the SetPopupBuffer - yes, it's "known broken" at the moment. It could actually be as easy as this being the problem (if CEF uses popups internally to represent selection), and we should probably fix that anyway. I filed a separate bug about that - #200.

@rastating
Copy link
Contributor

No problem! CefSharp helped a lot in one of my own projects, so just trying to contribute something back :)

I tried fixing this on the weekend but didn't get very far with it, I'm going to give it another shot this weekend. It seems that the support for this was implemented in CefSharp v1, so I was trying to pretty much just port over that functionality.

I'll send you a pull request through if I do manage to get it fixed!

@perlun
Copy link
Member Author

perlun commented Oct 28, 2013

Cool. 😄 Let me know if you get it sorted out and we can cooperate in getting the changes incorporated into master a.k.a. CefSharp3. 😉

@perlun
Copy link
Member Author

perlun commented Nov 6, 2013

Did you manage to find a workaround for this?

@rastating
Copy link
Contributor

I've still not had any luck with it unfortunately :(

@shen6041
Copy link
Contributor

@JanEggers
Copy link
Contributor

@shen6041 it is helpfull indeed. a pr is on the way

@perlun perlun mentioned this issue Mar 21, 2014
perlun added a commit that referenced this issue Mar 21, 2014
@jornh jornh modified the milestones: 3.29.0, 3.33.0 Mar 24, 2014
@perlun perlun closed this as completed Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants