Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameLoadEnd sometimes throws "The underlying frame is no longer valid - please check the IsValid property before calling" #2486

Closed
GrabzIt opened this issue Aug 15, 2018 · 7 comments
Labels
Milestone

Comments

@GrabzIt
Copy link
Contributor

GrabzIt commented Aug 15, 2018

  • What version of the product are you using?
    65.0.0

  • What architecture x86 or x64?
    x86

  • On what operating system?
    Windows 2008 R2, Windows 2012

  • Are you using WinForms, WPF or OffScreen?
    Offscreen

  • What steps will reproduce the problem?
    This seems to happen intermittently and I am not sure exactly why. However it happened in version 63,0.0 as well and seems to be originating from the OnLoadEnd event in c++ so I don't think it is to do with the order methods etc is called by my code. The stacktrace of the error is shown below.

  • What is the expected output? What do you see instead?

    Always successfully fire LoadEnd event

  • Please provide any additional information below.

The underlying frame is no longer valid - please check the IsValid property before calling!
at CefSharp.Internals.CefFrameWrapper.ThrowIfFrameInvalid()
at CefSharp.Internals.CefFrameWrapper.get_Url()
at CefSharp.Internals.ClientAdapter.OnLoadEnd(ClientAdapter* , scoped_refptr* browser, scoped_refptr* frame, Int32 httpStatusCode)

amaitland added a commit that referenced this issue Aug 16, 2018
@amaitland amaitland modified the milestones: 69.0.0, 67.0.0 Aug 16, 2018
@amaitland
Copy link
Member

This seems to happen intermittently and I am not sure exactly why. However it happened in version 63,0.0 as well and seems to be originating from the OnLoadEnd event in c++ so I don't think it is to do with the order methods etc is called by my code. The stacktrace of the error is shown below.

Strange that this has never been a problem before, I wonder under what circumstance frame.IsValid is false.

Change merged into cefsharp/67 branch with 64aec8f

Pretty sure this should be resolved.

@amaitland amaitland added the bug label Aug 16, 2018
@amaitland
Copy link
Member

@GrabzIt If this is a show stopping bug for you then let me know and I can look at releasing a 65.0.1 bug fix release.

@GrabzIt
Copy link
Contributor Author

GrabzIt commented Aug 16, 2018

Thanks for the fix :-D It's not a show stopper, but thanks for the offer of a new release!

@GrabzIt
Copy link
Contributor Author

GrabzIt commented Aug 16, 2018

@amaitland actually we have just checked our logs and it seems to have happened quite a lot in the last 24 hours alone. It would be great if you could do a bug fix release of version 65 for this, if it is not too much trouble.

Thanks for all your help as always.

amaitland added a commit that referenced this issue Aug 17, 2018
@amaitland amaitland modified the milestones: 67.0.0, 65.0.0 Aug 17, 2018
@amaitland
Copy link
Member

Packages are building now see https://ci.appveyor.com/project/cefsharp/cefsharp/build/65.0.0-CI2735

Will give them a quick test and push them to Nuget.org hopefully later today.

@GrabzIt
Copy link
Contributor Author

GrabzIt commented Aug 17, 2018

Awesome, thanks!

@amaitland
Copy link
Member

Packages have been pushed, should appear shortly.

@amaitland amaitland modified the milestones: 65.0.0, 65.0.1 Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants