Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - Add IAudioHandler #2714

Closed
amaitland opened this issue Apr 1, 2019 · 4 comments
Closed

Feature Request - Add IAudioHandler #2714

amaitland opened this issue Apr 1, 2019 · 4 comments
Labels
enhancement feature-request
Milestone
73.0.0

Comments

@amaitland
Copy link
Member

CEF has added the ability to capture the audio output to a buffer. Relevant commit.

https://bitbucket.org/chromiumembedded/cef/commits/9f41a27e586a6b557fc171d2f03b332c1338e8d2?at=3683

Requires addition of a new IAudioHandler interface and ChannelLayout` enum.
@amaitland amaitland added this to the 73.0.0 milestone Apr 10, 2019
amaitland added a commit to amaitland/CefSharp that referenced this issue Apr 17, 2019
@amaitland
Feature Request - Add IAudioHandler
d935414 
Initial implementation for cefsharp#2714
@amaitland amaitland mentioned this issue Apr 17, 2019
Merged
@amaitland
Copy link
Member Author

Initial PR at #2727 (very much a work in progress)

amaitland added a commit that referenced this issue May 3, 2019
@amaitland
Add IAudioHandler (#2727)
76e5a8d 
* Feature Request - Add IAudioHandler

- For performance reasons we return NULL if no audiohandler is assigned
- No example is provided currently

Initial implementation for #2714
@amaitland
Copy link
Member Author

IAudioHandler has been added, there is currently no working example as I ran out of time when writing one. The only area in question for the wrapper implementation is const float** data being mapped to IntPtr correctly. I believe it's correct though haven't been able to test.

It's important to note that the data received is RAW PCM data, you won't be able to write it directly to disk and play it in just any media player as it contains no header information.

amaitland added a commit that referenced this issue May 3, 2019
@amaitland
Add IAudioHandler (#2727)
91a2786 
* Feature Request - Add IAudioHandler

- For performance reasons we return NULL if no audiohandler is assigned
- No example is provided currently

Initial implementation for #2714
@amaitland
Copy link
Member Author

The Chromium implementation has changed so dramatically that CEF has removed support see https://bitbucket.org/chromiumembedded/cef/commits/1f893c76a97eaa88e3ff782b8e2e47dd0f5d27b2

Track https://bitbucket.org/chromiumembedded/cef/issues/2755/reimplement-audio-mirroring-for for details on when it will be reimplemented

Was removed from CefSharp in 802bb7f

@amaitland amaitland mentioned this issue Jun 14, 2020
Closed
@amaitland
Copy link
Member Author

#3152 will track the progress of re-adding the audio handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature-request
Projects
None yet
Milestone
73.0.0
Development

No branches or pull requests
1 participant
@amaitland