New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overriding JsDialogHandler is not hiding Javascript alerts #388
Comments
I haven't tried this out - just guessing - but have you tried with e.g.:
The documentation for the upstream CEF OnJSDialog API leaves me with the impression that it would want that. (We should really add this to the xmldocs too - iff I'm guessing right) |
@jornh changing to return true has not effect of javascript popup alerts
|
No, you are absolutely right. Thanks for reporting. If you step out of your handler code into
It always returns |
Glad, to help. |
@jornh, you fix? 😄 |
Yep yep yep 😃 |
Worth implementing the rest of CefJSDialogHandler while we're at it? |
I think we should leave that to after 31.0.0. It would be an enhancement - not an API change AFAICT? |
Works for me 😄 It simply adds to the API. |
my goal is to hide some javascript alerts that are popping up on my html
I have a custom JsDialogHandler with empty methods.
But I am still seeing javascript alerts. Is my override incorrect, or is there an issue in cefsharp JsHandler?
The text was updated successfully, but these errors were encountered: