Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winforms issue with mouse over titles #789

Closed
themullet opened this issue Feb 4, 2015 · 18 comments
Closed

Winforms issue with mouse over titles #789

themullet opened this issue Feb 4, 2015 · 18 comments

Comments

@themullet
Copy link

There seems to be an issue of lack of mouse over title popups on image assets with winforms.

Tested on CefSharp.MinimalExample.WinForms and current CefSharp.WinForms.Example.

Is this doable from a configure setting or an issue?

Noticed title popups are ok on CefSharp.MinimalExample.Wpf

@jornh
Copy link
Contributor

jornh commented Feb 4, 2015

I dug a bit around upstreams and found: http://www.magpcss.org/ceforum/viewtopic.php?f=6&t=11514&p=20387&hilit=Tooltip#p20387 It looks like CefSharp WinForms could be missing some manifest info. If you succeed in getting it working a PR would be very welcome 👍

@jornh jornh added the winforms label Feb 4, 2015
amaitland added a commit that referenced this issue Feb 4, 2015
@amaitland
Copy link
Member

@jornh Looks like you were on the money again 😄 I've added to the WinForms Example app.manifest and tooltips now appear.

See a961cbd

@jornh
Copy link
Contributor

jornh commented Feb 5, 2015

Guess it's safe to mark as 39.0.0 and add to ChangeLog since it's fixed in CefSharp.WinForms.Example 👍 @amaitland you're too fast to let new people get in with such low hanging PRs 😜 Lol

@themullet you can close the issue if you agree this is fixed - thanks a bunch for noticing and reporting!

@jornh jornh added this to the 39.0.0 milestone Feb 5, 2015
@amaitland
Copy link
Member

@jornh You may have a point, I should leave some 😄

FAQ entry required for this?

@jornh
Copy link
Contributor

jornh commented Feb 5, 2015

Hehe

FAQ entry required for this?

Nah, don't think so. I like that our FAQ is <= 10 points. Otherwise very few will bother reading it IMHO.

Maybe we should put a note with a link to the faq-able! issue type somewhere?

@amaitland
Copy link
Member

Maybe we should put a note with a link to the faq-able! issue type somewhere?

Excellent plan!

@themullet
Copy link
Author

Impressive replys, thanks for the direction.

Just try to get working in Visual Studio, trying to find how to import Microsoft.windows.common-controls. Added a app.manifest to my project copied and pasted from https://code.google.com/p/chromiumembedded/source/browse/trunk/cef3/tests/cefsimple/cefsimple.exe.manifest getting could not find file on compile.

@amaitland
Copy link
Member

You need to include the app.manifest in your project.

e.g. https://github.com/cefsharp/CefSharp/blob/master/CefSharp.WinForms.Example/CefSharp.WinForms.Example.csproj#L50

There's a menu item in Visual Studio, just google it, should be easy enough to find.

@themullet
Copy link
Author

Added in the app.manifest and getting
Error 1 Could not find file 'Microsoft.Windows.Common-Controls, Version=6.0.0.0, Culture=, PublicKeyToken=6595b64144ccf1df, ProcessorArchitecture=, Type=Win32'. App Name

Sorry to thick on this.

@amaitland
Copy link
Member

@themullet
Copy link
Author

Seems the issue is on my end now, thanks a lot for the ultra quick response and help.

Awesome project, cheers for all your hard work.

@themullet
Copy link
Author

Fixed the issue on my end now, disabled ClickOnce security settings and all ok now. Thanks again.

@jornh
Copy link
Contributor

jornh commented Feb 5, 2015

jornh referenced this issue in amaitland/CefSharp Jul 6, 2015
@Codehulk
Copy link

I realize this is an older issue but I'm having some trouble with the solution. By including the manifest, other controls outside of CEF are misbehaving. Anybody know how to apply the visualstyles stuff to CEF only and not to the rest of the application?

@jornh
Copy link
Contributor

jornh commented Aug 25, 2015

Have no experience with this and not really a CefSharp issue more a general Windows question I guess but https://msdn.microsoft.com/en-us/library/windows/desktop/bb773175%28v=vs.85%29.aspx#turnoff linked to above has a section on turning off the styling for a window or individual controls.

@treenewlyn
Copy link

  1. add app.manifest to vs project.

  2. open the project *.csproj with notepad

    2.1 add code:

  <PropertyGroup>
    <ApplicationManifest>app.manifest</ApplicationManifest>
  </PropertyGroup>

2.2 modify code:

    <None Include="app.manifest">
      <SubType>Designer</SubType>
    </None>

@amaitland
Copy link
Member

For reference VS has an Application Manifest File template. You can use the project properties to select the manifest. No manual editing required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants