Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anonymous function callback inside an object parameter #1729

Merged
merged 3 commits into from Jul 6, 2016

Conversation

gabrielbrieva
Copy link
Contributor

I added support to use anonymous function as callback inside an object.
So it is possible to do next:

bound.testCallbackFromObject({
  foo: "bar",
  callback: function(text) {
    console.log(text);
  }
});

It is possible to merge this feature to the project?

This is my first pull request :)

@@ -28,7 +29,18 @@ namespace CefSharp
/// </summary>
/// <param name="obj">The V8 value that should be converted.</param>
/// <returns>A corresponding .NET object.</returns>
static Object^ ConvertFromCef(CefRefPtr<CefV8Value> obj);
static Object^ ConvertFromCef(CefRefPtr<CefV8Value> obj);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this overload, just pass in nullptr. Formatting is out, spaces not tabs.

@amaitland
Copy link
Member

@Tuxan Thanks for the contribution 👍 Please review your code changes using the Files Changed tab above. Your formatting is out, Spaces not tabs.

It's too late in the release cycle for this to be included in 51.0.0. Can be included in the next major release.

@gabrielbrieva
Copy link
Contributor Author

@amaitland I done the changes you reviewed.

@amaitland
Copy link
Member

@Tuxan Thanks 👍 Will try to take it for a spin sometime this coming week.

@amaitland amaitland added this to the 53.0.0 milestone Jul 3, 2016
@amaitland amaitland merged commit 8a800b5 into cefsharp:master Jul 6, 2016
@amaitland
Copy link
Member

@Tuxan Merged with a few changes, nothing major 👍

18793c6
c8f6017

@gabrielbrieva
Copy link
Contributor Author

@amaitland Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants