Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixing #249

Closed
wants to merge 3 commits into from
Closed

Bug fixing #249

wants to merge 3 commits into from

Conversation

joaompneves
Copy link
Contributor

Several bug fixes:

  • Fixed null pointer exception after disposing webview
  • Fixed memory leak after unloading control
  • Replaced TryGetCefBrowser with GetCefBrowser in some methods to throw exception instead of ignoring the action

@perlun
Copy link
Member

perlun commented Feb 10, 2014

Hi,

This one I am more positive towards incorporating. I will just have to review it a bit more on my behalf first, to ensure that everything works as expected with these changes in place.

Thanks for your valuable contribution(s) to the project!

@perlun
Copy link
Member

perlun commented Mar 14, 2014

Sorry for the delay with this one. Would be good to get merged; we just have to weight it compared to trying to get CefSharp3 out the door...

@perlun
Copy link
Member

perlun commented May 10, 2014

Finally, started looking at this. The whitespace is a bit messed up (probably using tabs instead of spaces). Could you fix it?

@amaitland
Copy link
Member

Firstly thank you @joaompneves for the fine contribution! As we've released the first official version of CefSharp3 and there is nobody actively working on developing CefSharp1 I'm going to close this PR. If someone wishes to step-up and take over CefSharp1 maintenance and development then this can be reopened.

@amaitland amaitland closed this Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants