improved WebView resource cleanup #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach (var disposable in disposables) | ||
| { | ||
| disposable.Dispose(); | ||
| } | ||
| GC.Collect(); | ||
| GC.WaitForPendingFinalizers(); |
There was a problem hiding this comment.
Should we move these two lines also?
There was a problem hiding this comment.
nope the intention of this two lines is that the gc runns and cleans before CefShutdown is called. if the two lines are moved to instance cleanup then there will be a full gc cycle for each instance of webview and that just will slow things down.
There was a problem hiding this comment.
OK, cool. You're right - that makes sense. Merging your fine code now - thanks!
perlun
added a commit
that referenced
this pull request
Mar 26, 2014
Improved WebView resource cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.