Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #137: Set the stage to pack and push 31.0.0-pre1 CefSharp NuGets #314

Merged
merged 3 commits into from
Apr 15, 2014

Conversation

jornh
Copy link
Contributor

@jornh jornh commented Apr 6, 2014

  • Bump CefSharp.* version series from 3.<something> to the new 31.0.0-pre1. Note with this we don't even have a clash with unofficial version id's pushed to staging.nuget.org 😄
  • Change cef.redist dependency version indicator to allow auto-update or install of latest & greatest in the 3.1650.* series (this == less maintenance of dependencies across repos and we should be safe because we are in control of what gets pushed from the cef-binary repo)

Note: If you don't want to wait for the official NuGets to appear at www.nuget.org/packages/CefSharp.Wpf - but wan't some CefSharp 31.0.0 now - you can easily roll you own and depend on them by doing this:

  1. Build CefSharp from sources
  2. Modify the version in pack.bat to your own version e.g. 31.0.0-homegrown-pre1 to avoid confusion later on.
  3. Run pack.bat. For now ignore the error regarding the missing WinForms NuGet
  4. Put the .nupkg files in a local folder somewhere and set it up as a package source in VStudio

Just be aware of one thing if you do this; the binaries you build will not have a dependency on the Visual C++ 2012 Redist (as mentioned in the FAQ) but the Redist matching the VS201x version you build with!

…p#137

- Bump version series from 3.<something> to the new 31.0.0-pre1. Note with this we don't even have a clash with unofficial version id's pushed to staging.nuget.org :-)
- Change `cef.redist` dependency version indicator to allow auto-update or install of latest & greatest in the 3.1650.1562 series
@perlun
Copy link
Member

perlun commented Apr 14, 2014

So, should I build this now? (within the next few days)

@jornh
Copy link
Contributor Author

jornh commented Apr 15, 2014

Yes I really think so, if you can find the time! IMHO the best way to think of it is:

As a CefSharp.Wpf -Pre NuGet consumer would I rather as a default be served 3.29 or these additional changes ??

I have one loose end though: While being "under cover" and pushing to staging.nuget.org I experienced glitches which looked like http://nuget.codeplex.com/workitem/3677. That's why I opted for pushing only cef.redist x86 to the real nuget.org first. Our choices as I see it:

  1. Stay with the current x86 only (we are still in -Pre)
  2. Try pushing a "monolithic" cef.redist x86 + x64 - I don't know if we can end up with something broken up there? But then we can push newer revisions to fix it - ?
  3. Make both a x86 and a x86 "stack" - and maybe join them with a top package only containing references like this:
    cef.redist.x86 <- CS.Common.x86 <- CS.Wpf.x86
                                                  <- CS.Wpf
    cef.redist.x64 <- CS.Common.x64 <- CS.Wpf.x64

The NuGet issue 3677 above mention a 37MB package size - and each of our x86/x64 are around 26 MB

As you might suspect I'm a bit in love with option 3 - and I have prepared the x64 .nuspec pieces already ... but ... what's your (or even our NuGet customers - if some of them are here) opinion?

From a package consumers PoV getting e.g. the CS.Wpf.x64 only the would remove the "noise" of the current "broken" references to the .x86 CefSharp assemblies. But they of course have to make a decision.

Any other points to consider?

Ah, enough of a rant... In the end we just need to decide on something and get on with it ... your call! 😄

@perlun
Copy link
Member

perlun commented Apr 15, 2014

Ah, decisions... as if there aren't enough of them at work/home already. 😜

Anyway, I think having two packages will be quite awkward perhaps. There will be apps that will want to target both x86 and x64. How would we support that then? Perhaps it will work straight out of the box?

Nonetheless, I will merge this now and try to BUILD a new release. Yay! 😄

perlun added a commit that referenced this pull request Apr 15, 2014
For #137: Set the stage to pack and push 31.0.0-pre1 CefSharp NuGets
@perlun perlun merged commit 98e1295 into cefsharp:master Apr 15, 2014
@jornh
Copy link
Contributor Author

jornh commented Apr 15, 2014

Cool.. let me know if you run into any glitches!

@jornh jornh deleted the prepare-to-pack-31.0.0-pre1 branch April 15, 2014 19:42
@perlun
Copy link
Member

perlun commented Apr 15, 2014

Alright. A pre1 release has been made, and it has also been published on the Releases page (it actually says you made the release. 😉). Couldn't change it to myself.

Do you mind testing upgrading the MinimalExample etc? To see that it's working like it should?

@jornh
Copy link
Contributor Author

jornh commented Apr 15, 2014

Cool! I added you as owner to CEF SDK on NuGet BTW. Well maybe this Release page thing is something where we just should take a step back, to the old way, or figure something different out. I'll test with MinimalExample and report here. Just remeber there is no x64 in the CEF.Redist - should I try pushing a new -Pre4 of that tomorrow?

@jornh
Copy link
Contributor Author

jornh commented Apr 15, 2014

Here's my PM> log from VS2013 x86/Debug in MinimalExample - below

When googling to http://html5test.com it says I'm running Chrome 31 😄



Package Manager Console Host Version 2.8.50313.46

Type 'get-help NuGet' to see all available NuGet commands.

PM> Get-Package

Id                             Version              Description/Release Notes                                        
--                             -------              -------------------------                                        
CefSharp.Core                  3.29.0-pre0          The CefSharp Chromium-based browser component (Core components...
CefSharp.Wpf                   3.29.0-pre0          The CefSharp Chromium-based browser component (WPF control).     


PM> Update-Package CefSharp.Wpf -Prerelease
Updating 'CefSharp.Wpf' from version '3.29.0-pre0' to '31.0.0-pre1' in project 'CefSharp.MinimalExample.Wpf'.
Removing 'CefSharp.Wpf 3.29.0-pre0' from CefSharp.MinimalExample.Wpf.
Successfully removed 'CefSharp.Wpf 3.29.0-pre0' from CefSharp.MinimalExample.Wpf.
Removing 'CefSharp.Core 3.29.0-pre0' from CefSharp.MinimalExample.Wpf.
Successfully removed 'CefSharp.Core 3.29.0-pre0' from CefSharp.MinimalExample.Wpf.
Adding 'cef.redist 3.1650.1562-pre3' to CefSharp.MinimalExample.Wpf.
Installing 'cef.redist 3.1650.1562-pre3'.
Successfully installed 'cef.redist 3.1650.1562-pre3'.
Successfully added 'cef.redist 3.1650.1562-pre3' to CefSharp.MinimalExample.Wpf.
Adding 'CefSharp.Common 31.0.0-pre1' to CefSharp.MinimalExample.Wpf.
Installing 'CefSharp.Common 31.0.0-pre1'.
Successfully installed 'CefSharp.Common 31.0.0-pre1'.
Successfully added 'CefSharp.Common 31.0.0-pre1' to CefSharp.MinimalExample.Wpf.
Adding 'CefSharp.Wpf 31.0.0-pre1' to CefSharp.MinimalExample.Wpf.
Installing 'CefSharp.Wpf 31.0.0-pre1'.
Successfully installed 'CefSharp.Wpf 31.0.0-pre1'.
Successfully added 'CefSharp.Wpf 31.0.0-pre1' to CefSharp.MinimalExample.Wpf.
Uninstalling 'CefSharp.Wpf 3.29.0-pre0'.
Successfully uninstalled 'CefSharp.Wpf 3.29.0-pre0'.
Uninstalling 'CefSharp.Core 3.29.0-pre0'.
Successfully uninstalled 'CefSharp.Core 3.29.0-pre0'.

PM> Get-Package

Id                             Version              Description/Release Notes                                        
--                             -------              -------------------------                                        
cef.redist                     3.1650.1562-pre3     CEF - the Chromium Embedded Framework....                        
CefSharp.Common                31.0.0-pre1          The CefSharp Chromium-based browser component ('Core' and comm...
CefSharp.Wpf                   31.0.0-pre1          The CefSharp Chromium-based browser component (WPF control).     


PM> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants