-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #137: Set the stage to pack and push 31.0.0-pre1 CefSharp NuGets #314
Conversation
…p#137 - Bump version series from 3.<something> to the new 31.0.0-pre1. Note with this we don't even have a clash with unofficial version id's pushed to staging.nuget.org :-) - Change `cef.redist` dependency version indicator to allow auto-update or install of latest & greatest in the 3.1650.1562 series
So, should I build this now? (within the next few days) |
Yes I really think so, if you can find the time! IMHO the best way to think of it is:
I have one loose end though: While being "under cover" and pushing to staging.nuget.org I experienced glitches which looked like http://nuget.codeplex.com/workitem/3677. That's why I opted for pushing only
The NuGet issue 3677 above mention a 37MB package size - and each of our x86/x64 are around 26 MB As you might suspect I'm a bit in love with option 3 - and I have prepared the x64 From a package consumers PoV getting e.g. the Any other points to consider? Ah, enough of a rant... In the end we just need to decide on something and get on with it ... your call! 😄 |
Ah, decisions... as if there aren't enough of them at work/home already. 😜 Anyway, I think having two packages will be quite awkward perhaps. There will be apps that will want to target both Nonetheless, I will merge this now and try to BUILD a new release. Yay! 😄 |
For #137: Set the stage to pack and push 31.0.0-pre1 CefSharp NuGets
Cool.. let me know if you run into any glitches! |
Alright. A Do you mind testing upgrading the MinimalExample etc? To see that it's working like it should? |
Cool! I added you as owner to CEF SDK on NuGet BTW. Well maybe this Release page thing is something where we just should take a step back, to the old way, or figure something different out. I'll test with MinimalExample and report here. Just remeber there is no x64 in the CEF.Redist - should I try pushing a new -Pre4 of that tomorrow? |
Here's my PM> log from VS2013 x86/Debug in MinimalExample - below When googling to http://html5test.com it says I'm running Chrome 31 😄
|
CefSharp.*
version series from3.<something>
to the new31.0.0-pre1
. Note with this we don't even have a clash with unofficial version id's pushed to staging.nuget.org 😄cef.redist
dependency version indicator to allow auto-update or install of latest & greatest in the 3.1650.* series (this == less maintenance of dependencies across repos and we should be safe because we are in control of what gets pushed from the cef-binary repo)Note: If you don't want to wait for the official NuGets to appear at www.nuget.org/packages/CefSharp.Wpf - but wan't some CefSharp 31.0.0 now - you can easily roll you own and depend on them by doing this:
pack.bat
to your own version e.g.31.0.0-homegrown-pre1
to avoid confusion later on.pack.bat
. For now ignore the error regarding the missing WinForms NuGet.nupkg
files in a local folder somewhere and set it up as a package source in VStudioJust be aware of one thing if you do this; the binaries you build will not have a dependency on the Visual C++ 2012 Redist (as mentioned in the FAQ) but the Redist matching the VS201x version you build with!