Key Modifier not being sent to Browser #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sent through key modifier so things like Shift-LeftArrow as expected Also include Home key in list that gets sent to the browser directly
|
Sweet! - no longer jumping to other tabs in CefSharp.Wpf.Example just because ... ... you press Can't wait to push the merge button on this one too! Excellent clean work @amaitland 👍 |
jornh
added a commit
that referenced
this pull request
Apr 14, 2014
Key Modifier not being sent to Browser
| @@ -20,6 +20,8 @@ namespace CefSharp.Wpf | |||
| { | |||
| public class WebView : ContentControl, IRenderWebBrowser, IWpfWebBrowser | |||
| { | |||
| private static readonly Key[] KeysToSendtoBrowser = new[] { Key.Tab, Key.Home, Key.End, Key.Left, Key.Right, Key.Up, Key.Down }; | |||
There was a problem hiding this comment.
You could put these on separate lines, for readability.
|
OK will do BDFL ... tomorrow ... muzzzt have sleezzpzz now zzzz.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modifiers parameter to ManagedCefBrowserAdapter SendKeyEvent function
Sent through key modifier so things like Shift-LeftArrow work as expected
Also include Home and End keys in list that gets sent to the browser directly (now Shift->Home and Shift->End work correctly when selecting items in input fields)